Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize code #378

Merged
merged 18 commits into from
Dec 22, 2024
Merged

chore: modernize code #378

merged 18 commits into from
Dec 22, 2024

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke added the chore small nits label Dec 21, 2024
@jkroepke jkroepke force-pushed the refactor branch 2 times, most recently from 4539b4f to 66d29e6 Compare December 21, 2024 22:22
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 81.40351% with 106 lines in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (1a503b5) to head (88ba3ec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/oauth2/handler.go 63.63% 24 Missing and 8 partials ⚠️
internal/oauth2/utils.go 62.16% 10 Missing and 4 partials ⚠️
internal/oauth2/refresh.go 73.80% 6 Missing and 5 partials ⚠️
internal/openvpn/passthrough.go 75.67% 6 Missing and 3 partials ⚠️
cmd/daemon/root.go 85.18% 7 Missing and 1 partial ⚠️
internal/oauth2/provider.go 91.30% 5 Missing and 3 partials ⚠️
internal/openvpn/main.go 85.71% 4 Missing and 2 partials ⚠️
internal/openvpn/handler.go 88.88% 2 Missing and 2 partials ⚠️
internal/httphandler/handler.go 88.00% 2 Missing and 1 partial ⚠️
internal/oauth2/providers/generic/check.go 88.88% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   82.92%   82.82%   -0.10%     
==========================================
  Files          51       50       -1     
  Lines        3162     2859     -303     
==========================================
- Hits         2622     2368     -254     
+ Misses        412      376      -36     
+ Partials      128      115      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke merged commit da8a813 into main Dec 22, 2024
8 checks passed
@jkroepke jkroepke deleted the refactor branch December 22, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore small nits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant