Skip to content

Return null on illegal field acces #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return null on illegal field acces #948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions handlebars/src/main/java/com/github/jknack/handlebars/context/FieldValueResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,13 @@ public boolean matches(final FieldWrapper field, final String name) {
protected Object invokeMember(final FieldWrapper field, final Object context) {
try {
return field.get(context);
} catch (IllegalAccessException ex) {
// Illegal access to field is expected for classes from external modules
return null;
} catch (Exception ex) {
throw new IllegalStateException(
"Shouldn't be illegal to access field '" + field.getName()
+ "'", ex);
"Shouldn't be illegal to access field '" + field.getName()
+ "'", ex);
}
}

Expand Down