Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ScriptProcessorNode with AudioWorklet #6628

Open
bt90 opened this issue May 9, 2020 · 13 comments
Open

Replace ScriptProcessorNode with AudioWorklet #6628

bt90 opened this issue May 9, 2020 · 13 comments
Assignees
Labels
api Issue related to the external API (iframe) confirmed Confirmed bug, should not go stale feature-request Issue which suggest an idea, enhancement or feature to implement web Issue related to the web frontend

Comments

@bt90
Copy link

bt90 commented May 9, 2020

Is your feature request related to a problem you are facing?
Feature request.

Describe the solution you'd like
Firefox gained support for the AudioWorklet API in 76. It's now supported it in all major browsers except for Safari. Jitsi should use it in order to do the audio processing off the main thread and replace the ScriptProcessorNode which is considered deprecated.

@saghul
Copy link
Member

saghul commented May 11, 2020

Ping @andrei-gavrilescu

@saghul saghul added feature-request Issue which suggest an idea, enhancement or feature to implement web Issue related to the web frontend labels May 11, 2020
@andrei-gavrilescu
Copy link
Contributor

Awesome, we'll definitely get to that when we have the time.

@andrei-gavrilescu andrei-gavrilescu self-assigned this May 11, 2020
@luixxiul luixxiul added the api Issue related to the external API (iframe) label May 20, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Aug 22, 2020
@bt90
Copy link
Author

bt90 commented Aug 22, 2020

Ping

@stale stale bot removed the wontfix Issue won't be fixed label Aug 22, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Nov 21, 2020
@bt90
Copy link
Author

bt90 commented Nov 21, 2020

Pong

@stale stale bot removed the wontfix Issue won't be fixed label Nov 21, 2020
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Jul 21, 2021
@bt90
Copy link
Author

bt90 commented Jul 21, 2021

Ping

@stale stale bot removed the wontfix Issue won't be fixed label Jul 21, 2021
@bt90
Copy link
Author

bt90 commented Aug 18, 2021

The AudioWorklet API is now widely supported:

https://caniuse.com/mdn-api_audioworklet

@saghul
Copy link
Member

saghul commented Aug 19, 2021

A PR would be most welcome.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Jan 9, 2022
@bt90
Copy link
Author

bt90 commented Jan 9, 2022

Ping

@stale stale bot removed the wontfix Issue won't be fixed label Jan 9, 2022
@saghul saghul added the confirmed Confirmed bug, should not go stale label Jan 9, 2022
@shevchukma
Copy link

In the browser console messages like this

[Deprecation] The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead. (https://bit.ly/audio-worklet)
_initializeAudioContext @TrackVADEmitter.js:112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the external API (iframe) confirmed Confirmed bug, should not go stale feature-request Issue which suggest an idea, enhancement or feature to implement web Issue related to the web frontend
Projects
None yet
Development

No branches or pull requests

5 participants