Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url in seacherClient constructor is misleading as it only accepts a hostname #5

Open
futurekarol opened this issue Mar 2, 2023 · 1 comment

Comments

@futurekarol
Copy link
Contributor

According to the constructor signature searcherClient(url: string, authKeypair: Keypair) and the example const c = searcherClient(blockEngineUrl, keypair); the constructor expects a url for the block engine.

It errors when using BLOCK_ENGINE_URL=https://frankfurt.mainnet.block-engine.jito.wtf.
Instead, it expects just the hostname, like BLOCK_ENGINE_URL=frankfurt.mainnet.block-engine.jito.wtf.

Proposed solution:
make sure it accepts urls and not just hostnames to make it consistent with the signature, example and jito docs (https://jito-labs.gitbook.io/mev/searcher-resources/block-engine/mainnet-addresses)

@on1force
Copy link

on1force commented Aug 1, 2024

so simple yet generate so many confusions.. up on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants