Skip to content

Conversation

@DevXiaolan
Copy link
Contributor

No description provided.

@pioug pioug self-requested a review November 6, 2021 16:02
Copy link
Contributor

@pioug pioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many unnecessary changes. We can't merge it as it is. Please review your PR and focus solely on relevant changes.

@DevXiaolan
Copy link
Contributor Author

Sorry about my mistakes

@pioug pioug merged commit 9c70e7b into jira-node:master Nov 17, 2021
@DevXiaolan
Copy link
Contributor Author

well,
What are the conditions for entering the list of contributors? :)

@pioug
Copy link
Contributor

pioug commented Jan 13, 2022

You featured as a contributor in the release notes https://github.com/jira-node/node-jira-client/releases/tag/v7.2.0.

If you mean being members of the repo, I think I didn't give out an invitation because your PR wasn't good initially and it took 9 commits to get it right. Sorry for judging hard, but I am cautious because it's not really my project. You can keep making PRs, I'll do my best to review and merge them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants