Skip to content

Commit f2d5dcb

Browse files
Matthew Wilcox (Oracle)akpm00
Matthew Wilcox (Oracle)
authored andcommitted
bounds: support non-power-of-two CONFIG_NR_CPUS
ilog2() rounds down, so for example when PowerPC 85xx sets CONFIG_NR_CPUS to 24, we will only allocate 4 bits to store the number of CPUs instead of 5. Use bits_per() instead, which rounds up. Found by code inspection. The effect of this would probably be a misaccounting when doing NUMA balancing, so to a user, it would only be a performance penalty. The effects may be more wide-spread; it's hard to tell. Link: https://lkml.kernel.org/r/20231010145549.1244748-1-willy@infradead.org Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Fixes: 9057289 ("mm: numa: Change page last {nid,pid} into {cpu,pid}") Reviewed-by: Rik van Riel <riel@surriel.com> Acked-by: Mel Gorman <mgorman@techsingularity.net> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent b401b62 commit f2d5dcb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/bounds.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ int main(void)
1919
DEFINE(NR_PAGEFLAGS, __NR_PAGEFLAGS);
2020
DEFINE(MAX_NR_ZONES, __MAX_NR_ZONES);
2121
#ifdef CONFIG_SMP
22-
DEFINE(NR_CPUS_BITS, ilog2(CONFIG_NR_CPUS));
22+
DEFINE(NR_CPUS_BITS, bits_per(CONFIG_NR_CPUS));
2323
#endif
2424
DEFINE(SPINLOCK_SIZE, sizeof(spinlock_t));
2525
#ifdef CONFIG_LRU_GEN

0 commit comments

Comments
 (0)