Skip to content

Commit db946a4

Browse files
visitorckwakpm00
authored andcommitted
lib/sort: optimize heapsort for equal elements in sift-down path
Patch series "lib/sort: Optimize the number of swaps and comparisons". This patch series aims to optimize the heapsort algorithm, specifically targeting a reduction in the number of swaps and comparisons required. This patch (of 2): Currently, when searching for the sift-down path and encountering equal elements, the algorithm chooses the left child. However, considering that the height of the right subtree may be one less than that of the left subtree, selecting the right child in such cases can potentially reduce the number of comparisons and swaps. For instance, when sorting an array of 10,000 identical elements, the current implementation requires 247,209 comparisons. With this patch, the number of comparisons can be reduced to 227,241. Link: https://lkml.kernel.org/r/20240113031352.2395118-1-visitorckw@gmail.com Link: https://lkml.kernel.org/r/20240113031352.2395118-2-visitorckw@gmail.com Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 6db9d31 commit db946a4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/sort.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ void sort_r(void *base, size_t num, size_t size,
262262
* average, 3/4 worst-case.)
263263
*/
264264
for (b = a; c = 2*b + size, (d = c + size) < n;)
265-
b = do_cmp(base + c, base + d, cmp_func, priv) >= 0 ? c : d;
265+
b = do_cmp(base + c, base + d, cmp_func, priv) > 0 ? c : d;
266266
if (d == n) /* Special case last leaf with no sibling */
267267
b = c;
268268

0 commit comments

Comments
 (0)