From a17436962fd6f6abfec71b9e7f027b0ed7e7559c Mon Sep 17 00:00:00 2001 From: Steven Zou Date: Fri, 20 Apr 2018 14:59:28 +0800 Subject: [PATCH] Return the logger.Interface instead of the pointer of logger to avoid nil checking issue --- src/jobservice/job/impl/logger/job_logger.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/jobservice/job/impl/logger/job_logger.go b/src/jobservice/job/impl/logger/job_logger.go index 6ecdf45d2e3..2640e4337de 100644 --- a/src/jobservice/job/impl/logger/job_logger.go +++ b/src/jobservice/job/impl/logger/job_logger.go @@ -5,6 +5,7 @@ import ( "strings" "github.com/vmware/harbor/src/common/utils/log" + "github.com/vmware/harbor/src/jobservice/logger" ) //JobLogger is an implementation of logger.Interface. @@ -16,7 +17,7 @@ type JobLogger struct { //New logger //nil might be returned -func New(logPath string, level string) *JobLogger { +func New(logPath string, level string) logger.Interface { f, err := os.OpenFile(logPath, os.O_CREATE|os.O_WRONLY, 0644) if err != nil { return nil