Skip to content

Fix and improve LED brightness #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Conversation

killerbees19
Copy link
Contributor

Related: #23 & #22 (comment)

(Tested at FRITZ!Box 7530 International with FRITZ!OS 07.28)

Do you maybe know the possible values for dimValue?

1-3

I guess on your FritzBox 7530 the dimming is also not available, or?

It's available at the FRITZ!Box 7530 (International) 🤓

Bildschirmfoto_2021-11-28_18-49-00

On which OS are you currently? Could you maybe check if it is still working for you? Thx.

Currently I'm still at 07.28, but update to 07.29 is available since some weeks.

All led features are fully working at 07.28 with this patch. I'll redo the test when I'm at 07.29, but not before mid-december…

Without these patch nothing happens at LED_BRIGHTNESS. I think it's really important to send all arguments with both names:

  • led_brightness & dimValue
  • led_display & ledDisplay

Furthermore I've implemented an undocumented feature: LED_BRIGHTNESS 0 is identical to LED 0 (without changing current brightness)

(Tested at FRITZ!Box 7530 International with FRITZ!OS 07.28)
@jhubig jhubig merged commit 0c0c0f1 into jhubig:master Nov 28, 2021
@jhubig
Copy link
Owner

jhubig commented Nov 28, 2021

Great. Thanks a lot.
According to AVM Website (https://avm.de/service/wissensdatenbank/dok/FRITZ-Box-7530/3510_LEDs-der-FRITZ-Box-ausschalten/) it should not be possible with the FritzBox 7530. But you proved it that it is working 🥇

Have a good evening.

Cheers,
Johannes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants