Fix and improve LED brightness #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #23 & #22 (comment)
(Tested at FRITZ!Box 7530 International with FRITZ!OS 07.28)
1-3
It's available at the FRITZ!Box 7530 (International) 🤓
Currently I'm still at 07.28, but update to 07.29 is available since some weeks.
All led features are fully working at 07.28 with this patch. I'll redo the test when I'm at 07.29, but not before mid-december…
Without these patch nothing happens at LED_BRIGHTNESS. I think it's really important to send all arguments with both names:
led_brightness
&dimValue
led_display
&ledDisplay
Furthermore I've implemented an undocumented feature:
LED_BRIGHTNESS 0
is identical toLED 0
(without changing current brightness)