Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade our build matrix to test on Java 17 + 21 #23958

Closed
1 task
DanielFran opened this issue Oct 23, 2023 · 6 comments · Fixed by #24200
Closed
1 task

Upgrade our build matrix to test on Java 17 + 21 #23958

DanielFran opened this issue Oct 23, 2023 · 6 comments · Fixed by #24200
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: CI builds $100 https://www.jhipster.tech/bug-bounties/
Milestone
8.1.0

Comments

@DanielFran
Copy link
Member

DanielFran commented Oct 23, 2023 •
edited
Loading

Overview of the feature request

upgrade our build matrix to test on Java 17 + 21

Motivation for or Use Case
Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@DanielFran DanielFran added area: enhancement 🔧 theme: CI builds $100 https://www.jhipster.tech/bug-bounties/ $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ labels Oct 23, 2023
@mshima
Copy link
Member

mshima commented Oct 23, 2023

Mix java 17/21 or switch every test to Java 21?

@mraible
Copy link
Contributor

mraible commented Oct 23, 2023

I think we should test on both 17 and 21 since Spring Boot requires 17 as a minimum.

@DanielFran
Copy link
Member Author

DanielFran commented Oct 23, 2023 •
edited
Loading

I believe we should test both, using the default JAVA_VERSION = 17 + the bigger JAVA_COMPATIBLE_VERSIONS = 21

image

@DanielFran DanielFran changed the title Upgrade our build matrix to test on Java 21 Upgrade our build matrix to test on Java 17 + 21 Oct 23, 2023
@mraible
Copy link
Contributor

mraible commented Nov 3, 2023

17 + 21 was recommended at Devoxx.

@mshima mshima mentioned this issue Nov 13, 2023
Merged
6 tasks
@deepu105 deepu105 added this to the 8.1.0 milestone Dec 11, 2023
@mshima
Copy link
Member

mshima commented Feb 15, 2024

@DanielFran bounty claimed https://opencollective.com/generator-jhipster/expenses/187983

@DanielFran
Copy link
Member Author

@mshima approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: CI builds $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
8.1.0
Development

Successfully merging a pull request may close this issue.

test node 18/20 and java 17/21 matrix mshima/generator-jhipster
4 participants
@mraible @deepu105 @mshima @DanielFran