Skip to content

Commit c234ead

Browse files
committed
Allow 'console.warn()' in the minified js
1 parent 8f057e7 commit c234ead

File tree

5 files changed

+33
-12
lines changed

5 files changed

+33
-12
lines changed

dist/proxy-storage.js

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,24 @@ return /******/ (function(modules) { // webpackBootstrap
251251
}, value);
252252
}
253253

254+
/**
255+
* @private
256+
*
257+
* Try to parse a value
258+
*
259+
* @param {string} value: the value to parse
260+
* @return {any}
261+
*/
262+
function tryParse(value) {
263+
var parsed = void 0;
264+
try {
265+
parsed = JSON.parse(value);
266+
} catch (e) {
267+
parsed = value;
268+
}
269+
return parsed;
270+
}
271+
254272
/**
255273
* @private
256274
*
@@ -262,12 +280,7 @@ return /******/ (function(modules) { // webpackBootstrap
262280
*/
263281
function copyKeys(instance, storage) {
264282
Object.keys(storage).forEach(function (key) {
265-
var value = storage[key];
266-
try {
267-
instance[key] = JSON.parse(value);
268-
} catch (e) {
269-
instance[key] = value;
270-
}
283+
instance[key] = tryParse(storage[key]);
271284
});
272285
}
273286

@@ -377,7 +390,13 @@ return /******/ (function(modules) { // webpackBootstrap
377390
value: function getItem(key) {
378391
(0, _utils.checkEmpty)(key);
379392
var value = _proxyMechanism.proxy[this.__storage__].getItem(key);
380-
if (value === undefined) value = null;else value = JSON.parse(value);
393+
if (value === undefined) {
394+
delete this[key];
395+
value = null;
396+
} else {
397+
value = tryParse(value);
398+
this[key] = value;
399+
}
381400
var v = executeInterceptors('getItem', key, value);
382401
if (v !== undefined) value = v;
383402
return value;

dist/proxy-storage.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/proxy-storage.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/web-storage.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,10 @@ class WebStorage {
173173
getItem(key) {
174174
checkEmpty(key);
175175
let value = proxy[this.__storage__].getItem(key);
176-
if (value === undefined) value = null;
177-
else {
176+
if (value === undefined) {
177+
delete this[key];
178+
value = null;
179+
} else {
178180
value = tryParse(value);
179181
this[key] = value;
180182
}

webpack.uglify.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const config = {
2323
compress: {
2424
dead_code: true,
2525
drop_debugger: true,
26-
drop_console: true,
26+
drop_console: false,
2727
},
2828
mangle: {
2929
except: ['WebStorage'],

0 commit comments

Comments
 (0)