Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SASS deprecation of the navbar.scss #3858

Closed
sank64 opened this issue Jul 21, 2024 · 1 comment
Closed

Fix SASS deprecation of the navbar.scss #3858

sank64 opened this issue Jul 21, 2024 · 1 comment

Comments

@sank64
Copy link

sank64 commented Jul 21, 2024

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch bulma@1.0.1 for the project I'm working on.

The issue is referenced in this thread: #3856 (comment)

Here is the diff that solved my problem:

diff --git a/node_modules/bulma/sass/components/navbar.scss b/node_modules/bulma/sass/components/navbar.scss
index c755aff..ea07327 100644
--- a/node_modules/bulma/sass/components/navbar.scss
+++ b/node_modules/bulma/sass/components/navbar.scss
@@ -254,9 +254,12 @@ body {
 .#{iv.$class-prefix}navbar-burger {
   @extend %reset;
   @include mx.burger(2.5rem);
-  align-self: center;
-  margin-inline-start: auto;
-  margin-inline-end: 0.375rem;
+
+  & {
+    align-self: center;
+    margin-inline-start: auto;
+    margin-inline-end: 0.375rem;
+  }
 }
 
 .#{iv.$class-prefix}navbar-menu {

This issue body was partially generated by patch-package.

@jgthms
Copy link
Owner

jgthms commented Jul 25, 2024

Thanks. It's the solution for #3856

@jgthms jgthms closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants