Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable card titles in dark hero #291

Open
4 of 5 tasks
Qard opened this issue Aug 30, 2016 · 4 comments
Open
4 of 5 tasks

Unreadable card titles in dark hero #291

Qard opened this issue Aug 30, 2016 · 4 comments

Comments

@Qard
Copy link

Qard commented Aug 30, 2016

Checklist

  • This is about Bulma the CSS framework and not about the Bulma website
  • I'm using Bulma version [0.1.2]
  • My browser is: Chrome 52
  • This is a Sass issue: I'm using version [x.x.x]
  • I am sure this issue is not a duplicate?

Description

It seems putting a .card element inside the .hero-body of a .hero.is-dark element results in the title and subtitle being white on white, and thus unreadable.

Steps to Reproduce

  1. Make a dark hero element
  2. Put a card in it
  3. Fail...

Expected behavior: The hero title/subtitle style should not take priority over the card title/subtitle style.

Actual behavior: The hero title/subtitle style clobbers the card title/subtitle style, making them unreadable.

screenshot

@jgthms jgthms self-assigned this Mar 27, 2017
@kelle62819
Copy link

Ran into this as well. Any timeline on a fix?
I tried adding "is-dark" to card, but that doesn't work either.

@jgthms
Copy link
Owner

jgthms commented Jul 13, 2017

You can fix it with:

.hero.is-dark .card .title {
  color: #363636;
}

@Come2Daddy
Copy link
Contributor

Is fixed, to be closed.

@jgthms jgthms added pinned and removed pinned labels Jan 21, 2019
@softhouse-anthonkendel
Copy link

softhouse-anthonkendel commented Jul 20, 2023

Any plans on fixing this problem? We recently had encounter the same or similar problem.

We use the following template:

<section class="hero is-fullheight is-black">
  <section class="section">
    <div class="box">
      <p lass="title is-spaced is-4 has-text-dark">Title</p>
    </div>
  </section>
</section>

Due to the .box using a white background the .title disappears due to the .hero styles. To fix this we use the text utilities, i.e. .has-text-dark.

The hero seems to change all .title elements without regard on parents. See:

.hero.is-black .title, .hero.navbar.is-gaim-navbar .title {
  color: hsl(0, 0%, 100%);
}

Maybe make the .hero style more strict, i.e. only direct children? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants