Skip to content

Commit 0de20b7

Browse files
[APM] Remove link from active page in the breadcrumb (elastic#65473) (elastic#65624)
1 parent 9c81676 commit 0de20b7

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
*/
66

77
import { Location } from 'history';
8-
import { BreadcrumbRoute, getBreadcrumbs } from '../ProvideBreadcrumbs';
9-
import { RouteName } from '../route_config/route_names';
8+
import { BreadcrumbRoute, getBreadcrumbs } from './ProvideBreadcrumbs';
9+
import { RouteName } from './route_config/route_names';
1010

1111
describe('getBreadcrumbs', () => {
1212
const getTestRoutes = (): BreadcrumbRoute[] => [

x-pack/plugins/apm/public/components/app/Main/UpdateBreadcrumbs.tsx

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,18 @@ function getTitleFromBreadCrumbs(breadcrumbs: Breadcrumb[]) {
3030

3131
class UpdateBreadcrumbsComponent extends React.Component<Props> {
3232
public updateHeaderBreadcrumbs() {
33-
const breadcrumbs = this.props.breadcrumbs.map(({ value, match }) => ({
34-
text: value,
35-
href: getAPMHref(match.url, this.props.location.search)
36-
}));
33+
const breadcrumbs = this.props.breadcrumbs.map(
34+
({ value, match }, index) => {
35+
const isLastBreadcrumbItem =
36+
index === this.props.breadcrumbs.length - 1;
37+
return {
38+
text: value,
39+
href: isLastBreadcrumbItem
40+
? undefined // makes the breadcrumb item not clickable
41+
: getAPMHref(match.url, this.props.location.search)
42+
};
43+
}
44+
);
3745

3846
document.title = getTitleFromBreadCrumbs(this.props.breadcrumbs);
3947
this.props.core.chrome.setBreadcrumbs(breadcrumbs);

x-pack/plugins/apm/public/components/app/Main/__snapshots__/UpdateBreadcrumbs.test.tsx.snap

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)