Add TableCaption to ODT styles.xml #10055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #10053 -- we add "TableCaption" to the styles as this is what Pandoc uses in the generated content.
|
Thanks! the only problem is the overlong line in the commit message (wrap to 80 cols, please). |
|
Hm, I cannot rewrite the history of the first commit message (I'm using github's interface), I'll redo the pull from a new branch and close this one... |
|
See #10058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10053 -- ODT output currently has no styling for table captions, and yet the writer is assigning the
TableCaptionstyle to table captions. But the reference.odt doesn't contain that style. We addTableCaptionto the styles.xml as this is what Pandoc uses in the generated content. My current Libreoffice writes the style xml a bit differently, but I tried to follow the current style.xml formatting.