Google Docs (Docx) <li>'s have <blockquotes> inside

[StephanMeijer]

Attachments

List Item Test.docx

Problem

In conversion .docx -> .html, all <li>'s have blockquotes inside.

This is likely because Google Docs doesn't add a pStyle in the pPr of list (items) where Microsoft Word does:

Google Docx' `document.xml`

        <w:p w:rsidR="00000000" w:rsidDel="00000000" w:rsidP="00000000" w:rsidRDefault="00000000" w:rsidRPr="00000000"
             w14:paraId="00000012">
            <w:pPr>
                <w:numPr>
                    <w:ilvl w:val="0"/>
                    <w:numId w:val="1"/>
                </w:numPr>
                <w:ind w:left="720" w:hanging="360"/>
                <w:rPr>
                    <w:u w:val="none"/>
                </w:rPr>
            </w:pPr>
            <w:r w:rsidDel="00000000" w:rsidR="00000000" w:rsidRPr="00000000">
                <w:rPr>
                    <w:rtl w:val="0"/>
                </w:rPr>
                <w:t xml:space="preserve">It uses ‘-’ in the source document.</w:t>
            </w:r>
        </w:p>

Microsoft Word' `document.xml`

       <w:p w:rsidR="00E71277" w:rsidRDefault="00E71277" w:rsidP="00E71277">
            <w:pPr>
                <w:pStyle w:val="Normaalweb"/>
                <w:numPr>
                    <w:ilvl w:val="0"/>
                    <w:numId w:val="1"/>
                </w:numPr>
                <w:shd w:val="clear" w:color="auto" w:fill="FFFFFF"/>
                <w:spacing w:before="0" w:beforeAutospacing="0" w:after="225" w:afterAutospacing="0"/>
                <w:jc w:val="both"/>
                <w:rPr>
                    <w:rFonts w:ascii="Open Sans" w:hAnsi="Open Sans" w:cs="Open Sans"/>
                    <w:color w:val="000000"/>
                    <w:sz w:val="21"/>
                    <w:szCs w:val="21"/>
                    <w:lang w:val="en-US"/>
                </w:rPr>
            </w:pPr>
            <w:proofErr w:type="spellStart"/>
            <w:r>
                <w:rPr>
                    <w:rFonts w:ascii="Open Sans" w:hAnsi="Open Sans" w:cs="Open Sans"/>
                    <w:color w:val="000000"/>
                    <w:sz w:val="21"/>
                    <w:szCs w:val="21"/>
                    <w:lang w:val="en-US"/>
                </w:rPr>
                <w:t>Een</w:t>
            </w:r>
            <w:proofErr w:type="spellEnd"/>
            <w:r>
                <w:rPr>
                    <w:rFonts w:ascii="Open Sans" w:hAnsi="Open Sans" w:cs="Open Sans"/>
                    <w:color w:val="000000"/>
                    <w:sz w:val="21"/>
                    <w:szCs w:val="21"/>
                    <w:lang w:val="en-US"/>
                </w:rPr>
                <w:t xml:space="preserve"> </w:t>
            </w:r>
            <w:proofErr w:type="spellStart"/>
            <w:r>
                <w:rPr>
                    <w:rFonts w:ascii="Open Sans" w:hAnsi="Open Sans" w:cs="Open Sans"/>
                    <w:color w:val="000000"/>
                    <w:sz w:val="21"/>
                    <w:szCs w:val="21"/>
                    <w:lang w:val="en-US"/>
                </w:rPr>
                <w:t>ongeordende</w:t>
            </w:r>
            <w:proofErr w:type="spellEnd"/>
            <w:r>
                <w:rPr>
                    <w:rFonts w:ascii="Open Sans" w:hAnsi="Open Sans" w:cs="Open Sans"/>
                    <w:color w:val="000000"/>
                    <w:sz w:val="21"/>
                    <w:szCs w:val="21"/>
                    <w:lang w:val="en-US"/>
                </w:rPr>
                <w:t xml:space="preserve"> </w:t>
            </w:r>
            <w:proofErr w:type="spellStart"/>
            <w:r>
                <w:rPr>
                    <w:rFonts w:ascii="Open Sans" w:hAnsi="Open Sans" w:cs="Open Sans"/>
                    <w:color w:val="000000"/>
                    <w:sz w:val="21"/>
                    <w:szCs w:val="21"/>
                    <w:lang w:val="en-US"/>
                </w:rPr>
                <w:t>lijst</w:t>
            </w:r>
            <w:proofErr w:type="spellEnd"/>
        </w:p>

I suspect the error might be in src/Text/Pandoc/Readers/Docx.hs:

src/Text/Pandoc/Readers/Docx.hs

paragraphStyleToTransform :: PandocMonad m => ParagraphStyle -> DocxContext m (Blocks -> Blocks)
paragraphStyleToTransform pPr =
  let stylenames = map getStyleName (pStyle pPr)
      transform = if (`elem` listParagraphStyles) `any` stylenames || relativeIndent pPr <= 0
                  then id
                  else blockQuote
  in do
    extStylesEnabled <- asks (isEnabled Ext_styles . docxOptions)
    return $ foldr (\parStyle transform' ->
        (parStyleToTransform extStylesEnabled parStyle) . transform'
      ) transform (pStyle pPr)

parStyleToTransform :: Bool -> ParStyle -> Blocks -> Blocks
parStyleToTransform extStylesEnabled parStyle@(getStyleName -> styleName)
  | (styleName `elem` divsToKeep) || (styleName `elem` listParagraphStyles) =
      divWith ("", [normalizeToClassName styleName], [])
  | otherwise =
      (if extStylesEnabled then divWith (extraAttr parStyle) else id)
      . (if isBlockQuote parStyle then blockQuote else id)

Version

Latest commit.

[StephanMeijer]

Same for .odt so it seems.

[jgm]

Looked at this quickly. It looks as if the Google version repeats the list indentation: it is in the style for the list level (in numbering.xml), but it gets repeated in document.xml as a paragraph property. Pandoc sees this explicit indentation and assumes this is a block quote (our default treatment of indented paragraphs).

It's probably not a bug for them to repeat this list indentation, so we need to do something more complicated, and compare any specified indentation to the default indentation defined in numbering.xml for that list level.

[StephanMeijer]

Can't we use numPr in pPr to assume that if numPr is present, the element is probably not a BlockQuote?

[jgm]

Well, you might have a block quote in a list item.

- Like
- > this

The way ooxml does things, the paragraph will have both numPr and properties relevant to a block quote.

[StephanMeijer]

Fair. But that would be based on style then, not indent. e.g. if something is indented and has a numbering, it probably is not a blockquote. If something has a numbering and is of a blockquote style, it probably is a blockquote in a list.. If something is indented and does not have a numbering, it is probably a blockquote

[jgm]

that would be based on style then, not indent

That's the problem, if I recall. We found that there isn't a distinctive style used for block quotes in Word documents generally, so @jkr based it on indentation...

It might be reasonable though to disable this inside list items, if there isn't a better solution.

[StephanMeijer]

@jgm There are several styles, but inconsistent across versions of Microsoft Office. So I think in case there is no specific style defined, then it would be reasonable to regard it as regular list item.

[jgm]

Ordinary users often create block quotes just by indenting...that's we we found empirically.

[jgm]

I think I've got a good fix.

[StephanMeijer]

I think I've got a good fix.

Oh nice!