ICML Writer: Image object does not fit to frame

[ksesong]

Given an image set up using the following markdown string ![](./test.png){width=15cm}, the resulting icml file does not create an image object that fits to the frame, here is a screenshot in InDesign:

(The brown rectangle corresponds to the image object, and the blue one to the image frame.)

I have copied the test files onto a dedicated repository ksesong/pandoc-image-fitting, with the icml file compiled from pandoc 2.11.2. The problem is not specific to this particular image file, and I've tried various width units for the same effect.

[jgm]

I see, so the dimensions are applied to the frame, but the image itself is not changed?
@mb21 may be able to comment.

[ksesong]

Yes, the scaling of the image does not fit the frame, sometimes the image is smaller than the frame (as in the example), sometimes it is bigger, but I haven't managed to identify a pattern.

[mb21]

@ksesong I think I've fixed this with #6946... testing certainly welcome...

@jgm seems he needs to build from source, or wait until we merge it and test the nightly build? as https://github.com/jgm/pandoc/actions/runs/417415033 doesn't have any artifacts...

[jgm]

I've merged, so there should be a nightly available tomorrow.

[ksesong]

I have tried the master version, and it mostly works. Some rare images of my set remain problematic. I've tried to find out why most images did fit properly and some don't, but I couldn't find a reason.

I thought these images were invalid, but pandoc hasn't raised any warning, and jpeginfo hasn't detected any anomaly, and they could be opened as normal with an image editor. I finally tried to re-save these images, and this solved the fitting. I have included one problematic image in the repository, so you may want to have a look.

[jgm]

I don't see what could be problematic about this image.
Pandoc calculates the following size for it: if this is wrong, that may be the issue.

ImageSize {pxX = 850, pxY = 1026, dpiX = 143, dpiY = 143}

The dpi of 143 is a bit odd. Interestingly, macos Preview says the dpi for this image is 144. So maybe pandoc has an off-by-one-error?

[ksesong]

The invalid image is this one, not the screenshot that I included in the comment (which is valid). Sorry for the confusion.

[mb21]

The problem seems indeed to be in jpegSize:

for test-2:

ImageSize {pxX = 72, pxY = 72, dpiX = 72, dpiY = 72}

for test-2-resave.jpg (which is after resaving the file in Photoshop and which seems correct):

ImageSize {pxX = 2189, pxY = 1247, dpiX = 72, dpiY = 72}

[jgm]

Wait, I thought the problematic image was the one displayed above -- which is a png.