Command Summary - Separate Module Table View from Artifacts Tree #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
changed the title
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
eyalbe4
requested changes
Sep 4, 2024
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR separates the logic for generating markdown related to modules.
Details:
The module display is now divided into two subsections:
Modules with scan results (currently, this applies only to Docker images).
Modules without scan results (e.g., an npm module that is packaged into a tar file and then deleted, which we currently cannot scan easily with a JF command).
Introduced refactoring to improve code maintainability for the future.
Made minor adjustments to titles and UI elements for a better user experience.
Before - Npm modules is displayed on a table
After - Generic module is displayed without table: