-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XYPlot doesn't handle noDataMessage correctly #36
Comments
Thinking a bit further about it, the plot would actually need info from the renderer if any data was rendered or not. Imagine a dataset with only null-values. The renderer wouldn't render anything but the plot couldn't know and would thus return |
It’s a tricky one, because if the emptyOrNull() check returns false then there is data, so in a sense we shouldn’t display the ‘no data message’ even if nothing is rendered for other reasons. Maybe there is a case for another message to be displayed when there is data but for some reason rendering is not possible. Best regards, David On 11 Feb 2015, at 09:32, Martin Höller notifications@github.com wrote:
|
Well, your arguments are valid. Still, if nothing is rendered it's going to be an empty chart and a message could make sense. Maybe we really would need another message. |
The XYPlot class has a method render() that states in the JavaDoc:
There is a check if the dataset is emptyOrNull. Right after this the foundData-flag is set to true, followed by conditional returns that skip rendering because of missing axes and the like. In this case, the returned value should IMHO still be false, as nothing was rendered.
The text was updated successfully, but these errors were encountered: