Doesn't work for deconstruction if there is an intermediate step

[gunar]

Works (gives error)

const { flow, get, reject} = require('lodash/fp')
flow(reject('a'), reject('b'))

Doesn't work (no error)

const _ = require('lodash/fp')
const { flow, get, reject } = _
flow(reject('a'), reject('b'))

[jfmengels]

(Man, I was sure I answered this one, sorry for the delay)

Yeah, this is kind of a hard thing to do with ESLint, as you have to "manually" track the variables, the assignations and stuff, which is possible, but just requires quite a lot more time and investment. It is also a lot more fragile if the values are re-assigneable or some new variable named like Lodash gets introduced through a variable or a parameter.

var _ = require('lodash/fp')
if (CONDITION) {
  _ = require('something-else');
}
var { flow, get, reject } = _
flow(reject('a'), reject('b'))

I have added the help wanted label so that if someone has experience with this and wants to tackle it, they can have a go at it (and I'd be very grateful!), but this is definitely not an issue for a beginner. I will probably not tackle this issue before quite a while either. Maybe one day I'll build a tool to help solve this kind of thing, as it is frustratingly recurrent.

Out of curiosity, is this something that you noticed, or something you have in your code and that you noticed didn't give you an error? I'm wandering this is really a problem, or just a warning. Thanks for reporting though ;)

[gunar]

Cool. Thank you so much! 🙌 It's something I noticed that didn't give me an error. I'll keep an eye on this issue.