Alias relations in search order.

[jwg4]

The function sqlalchemy.orm.aliased() creates an aliased version of a model for use in joins, ie "JOIN foo ON foo.id = bar.foo_id" is replaced by "JOIN foo AS foo1 ON foo1.id = bar.foo_id". Aliasing every join in search order is the easiest way of making sure that there is no conflict between two orders on the same model.

This patch fixes the unit test broken on master, tests.test_search.TestQueryCreation.test_order_by_two_different_fields_of_the_same_relation

[jfinkels]

Please check if this is still an issue with the development version, and if so, create a new pull request with a test case demonstrating the erroneous behavior.

[jwg4]

Thanks for all your work on the new version, but I feel the way this has been handled wasn't very respectful of other collaborators' time. For months and months lots of pull requests were completely ignored, including ones fixing bugs which were important to users, and a fix to one bug which broke the tests, making development progress harder for everyone. During this time lots of people took the time to make contributions, and heard nothing at all back. Now all this work has been made obsolete all of a sudden, and you are expecting people to update their tests, create new patches, and resubmit.
I understand that it's difficult to keep integrating contributions against a moving target of a new version, even if they fix important bugs. But it would have been nice if sometime between August, when I first opened the PR, and December, when I made changes to it, you could have found the time to let me know that there was a new version in development, and no changes to the old version were likely to be accepted.

[jfinkels]

Hi, @jwg4! You are absolutely right, of course, and I apologize. I'm working on improving my communication. If you have any other concerns, please email me, my contact information is on the README page.

[jwg4]

Thanks for your courteous message @jfinkels. I appreciate all the work that you are putting in. Looking forward to figuring out how I can contribute to the new version of Flask-Restless!

[jfinkels]

I have added the fix you suggested here in commit 64a5711. Thank you, and sorry again for the delay!