Move initial actions to module declarations

Author: jfcere

src/core/app.tsx

@@ -26,7 +26,6 @@ const mapStateToProps = ({ core }: CoreAwareState) => {
 };
 
 const mapDispatchToProps = {
-  loadTheme: actions.loadTheme,
   setTheme: actions.setTheme,
 };
 
@@ -38,7 +37,6 @@ const App: React.FunctionComponent<Props> = (props) => {
   const {
     theme,
     loadingTheme,
-    loadTheme,
     setTheme,
   } = props;
 
@@ -48,10 +46,6 @@ const App: React.FunctionComponent<Props> = (props) => {
 
   const themesMap = availableThemes;
 
-  useEffect(() => {
-    loadTheme();
-  }, [loadTheme]);
-
   useEffect(() => {
     if (loadingTheme === false) {
       setMuiTheme(themesMap.get(theme));

src/core/core.module.ts

@@ -1,5 +1,6 @@
 import { ISagaModule } from 'redux-dynamic-modules-saga';
 
+import { loadTheme } from './store/core.actions';
 import coreReducer, { CoreState } from './store/core.reducer';
 import coreSaga from './store/core.saga';
 
@@ -11,6 +12,8 @@ export const CoreModule: ISagaModule<CoreAwareState> = {
   id: 'core',
   reducerMap: { core: coreReducer },
   sagas: [coreSaga],
-  initialActions: [],
+  initialActions: [
+    loadTheme(),
+  ],
   finalActions: [],
 };

src/hero/hero.module.ts

@@ -1,5 +1,6 @@
 import { ISagaModule } from 'redux-dynamic-modules-saga';
 
+import { loadHeroes, loadPowers } from './store/hero.actions';
 import heroReducer, { HeroState } from './store/hero.reducer';
 import heroSaga from './store/hero.saga';
 
@@ -11,6 +12,9 @@ export const HeroModule: ISagaModule<HeroAwareState> = {
   id: 'hero',
   reducerMap: { hero: heroReducer },
   sagas: [heroSaga],
-  initialActions: [],
+  initialActions: [
+    loadHeroes(),
+    loadPowers(),
+  ],
   finalActions: [],
 };

src/hero/hero.tsx

@@ -1,5 +1,5 @@
 import { Box, Card, Hidden, Snackbar, Typography } from '@material-ui/core';
-import React, { useEffect } from 'react';
+import React from 'react';
 import { connect, ConnectedProps } from 'react-redux';
 import { DynamicModuleLoader } from 'redux-dynamic-modules';
 
@@ -23,8 +23,6 @@ const mapStateToProps = ({ hero }: HeroAwareState) => {
 
 const mapDispatchToProps = {
   addHero: actions.addHero,
-  loadHeroes: actions.loadHeroes,
-  loadPowers: actions.loadPowers,
   hideSnackbar: actions.hideSnackbar,
   removeHero: actions.removeHero,
   setViewMode: actions.setViewMode,
@@ -45,20 +43,13 @@ const Hero: React.FunctionComponent<Props> = (props) => {
     snackbarOpen,
     viewMode,
     addHero,
-    loadHeroes,
-    loadPowers,
     hideSnackbar,
     removeHero,
     selectHero,
     setViewMode,
     updateHero,
   } = props;
 
-  useEffect(() => {
-    loadHeroes();
-    loadPowers();
-  }, [loadHeroes, loadPowers]);
-
   const onSnackbarClose = (event: React.SyntheticEvent | React.MouseEvent, reason?: string) => {
     if (reason !== 'clickaway') {
       hideSnackbar();