Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review HTTP/2 DATA frame queueing #4318

Closed
sbordet opened this issue Nov 16, 2019 · 3 comments
Closed

Review HTTP/2 DATA frame queueing #4318

sbordet opened this issue Nov 16, 2019 · 3 comments
Assignees
Labels
Enhancement Stale For auto-closed stale issues and pull requests

Comments

@sbordet
Copy link
Contributor

sbordet commented Nov 16, 2019

Jetty version
10.0.0

Java version
11

Description
With the resolution of #3951, HTTP2Stream now queues DATA frames up to the flow control window size, and delivers them to listeners only if there is demand.

Before #3951, HTTP2Stream was delivering DATA frames to listeners immediately, so the queuing was happening in 2 places: either HttpInput for normal HTTP requests, or HTTP2StreamEndPoint in case of CONNECT requests.

I think we can remove the queuing from both HttpInput and HTTP2StreamEndPoint.

For HttpInput we need to consider the effects with HTTP/1.1, which I already think it overrides HttpInput in all the relevant places to not use its queuing features.

@gregw thoughts?

@gregw
Copy link
Contributor

gregw commented Nov 16, 2019

Correct, the queueing in HttpInput is only there for H2 so if it is not needed, we can probably substantially simplify HttpInput.

For h1, there is a produce API mechanism that could be adapted to take from a queue?

@sbordet
Copy link
Contributor Author

sbordet commented Mar 24, 2021

Fixed in 10.0.0 via #4556.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Mar 25, 2022
@sbordet sbordet closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Stale For auto-closed stale issues and pull requests
Projects
None yet
Development

No branches or pull requests

3 participants