You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
When reviewing PR #12420 it was noticed that the portion of the NCSA format that means "the first line of the HTTP request" isn't being handled properly in case of errors.
We wind up with BAD /badMessage HTTP/1.0 instead of the actual first line of the HTTP request.
I realize this isn't a thing in HTTP/2 and HTTP/3, but for HTTP/1.x we should strive to accomplish that properly.
The definition of NCSA combined format can be defined like this ...
%h %l %u %t "%r" %s %b "%{Referer}i" "%{User-agent}i"
%h: the client hostname or IP address
%l: the client identifier or - if none is set
%u: the username used by the client for authentication or - if none is set
%t: the date and time of the HTTP request
%r: the first line of the HTTP request
%s: the status code of the HTTP response
%b: the byte size of the HTTP response
%{Referer}i: the URL that linked to the requested page or - if none is set
%{User-agent}i: the web browser and platform used by the client
This is the structure that NCSA tooling (like varnish) uses when it parses the already produced NCSA request log.
The text was updated successfully, but these errors were encountered:
Jetty version(s)
12.0.14
Jetty Environment
Any
Java version/vendor
(use: java -version)
Any
OS type/version
Any
Description
When reviewing PR #12420 it was noticed that the portion of the NCSA format that means "the first line of the HTTP request" isn't being handled properly in case of errors.
We wind up with
BAD /badMessage HTTP/1.0
instead of the actual first line of the HTTP request.I realize this isn't a thing in HTTP/2 and HTTP/3, but for HTTP/1.x we should strive to accomplish that properly.
The definition of NCSA combined format can be defined like this ...
This is the structure that NCSA tooling (like varnish) uses when it parses the already produced NCSA request log.
The text was updated successfully, but these errors were encountered: