Skip to content

Commit 420750a

Browse files
committed
Merge branch 'ABenassi87-issue-50'
2 parents 5dbb94a + d6d6841 commit 420750a

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ dist/
77
.env
88
debug/lib
99

10+
.idea/
11+
1012
# Created by https://www.gitignore.io/api/node
1113

1214
### Node ###
@@ -67,8 +69,6 @@ typings/
6769
.yarn-integrity
6870

6971
# dotenv environment variables file
70-
.env
71-
7272
# parcel-bundler cache (https://parceljs.org/)
7373
.cache
7474

README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,9 @@ export type LiteralType =
341341
| 'DATE_LITERAL'
342342
| 'DATE_N_LITERAL';
343343
export type FieldType = Field | FieldFunctionExpression | FieldRelationship | FieldSubquery | FieldTypeOf;
344+
export type OrderByCriterion = 'ASC' | 'DESC';
345+
export type NullsOrder = 'FIRST' | 'LAST';
346+
export type GroupByType = 'CUBE' | 'ROLLUP';
344347

345348
export interface Field {
346349
type: 'Field';
@@ -428,13 +431,13 @@ export interface Condition {
428431
export interface OrderByClause {
429432
field?: string;
430433
fn?: FunctionExp;
431-
order?: 'ASC' | 'DESC';
432-
nulls?: 'FIRST' | 'LAST';
434+
order?: OrderByCriterion;
435+
nulls?: NullsOrder;
433436
}
434437

435438
export interface GroupByClause {
436439
field: string | string[];
437-
type?: 'CUBE' | 'ROLLUP';
440+
type?: GroupByType;
438441
}
439442

440443
export interface HavingClause {
@@ -470,6 +473,7 @@ export interface WithDataCategoryCondition {
470473
selector: GroupSelector;
471474
parameters: string[];
472475
}
476+
473477
```
474478

475479

lib/models/SoqlQuery.model.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ export type LiteralType =
1616
| 'DATE_LITERAL'
1717
| 'DATE_N_LITERAL';
1818
export type FieldType = Field | FieldFunctionExpression | FieldRelationship | FieldSubquery | FieldTypeOf;
19+
export type OrderByCriterion = 'ASC' | 'DESC';
20+
export type NullsOrder = 'FIRST' | 'LAST';
21+
export type GroupByType = 'CUBE' | 'ROLLUP';
1922

2023
export interface Field {
2124
type: 'Field';
@@ -103,13 +106,13 @@ export interface Condition {
103106
export interface OrderByClause {
104107
field?: string;
105108
fn?: FunctionExp;
106-
order?: 'ASC' | 'DESC';
107-
nulls?: 'FIRST' | 'LAST';
109+
order?: OrderByCriterion;
110+
nulls?: NullsOrder;
108111
}
109112

110113
export interface GroupByClause {
111114
field: string | string[];
112-
type?: 'CUBE' | 'ROLLUP';
115+
type?: GroupByType;
113116
}
114117

115118
export interface HavingClause {

0 commit comments

Comments
 (0)