Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docs regarding testSequencer #9174

Merged
merged 8 commits into from
May 3, 2020

Conversation

saiumesh535
Copy link
Contributor

@saiumesh535 saiumesh535 commented Nov 13, 2019

Summary

While trying to make run jest test cases in the required sequence, it was a little difficult to find and how to add testSequencer config. So Added example config for testSequencer. It will help and makes easier for users to run.

Test plan

Not required as we updated only docs.

@facebook-github-bot
Copy link
Contributor

Hi saiumesh535! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you updated the versioned docs as well? 24.8 and 24.9 have it

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #9174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9174   +/-   ##
=======================================
  Coverage   64.82%   64.82%           
=======================================
  Files         279      279           
  Lines       11740    11740           
  Branches     2885     2885           
=======================================
  Hits         7610     7610           
  Misses       3511     3511           
  Partials      619      619

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0996912...9a1b92e. Read the comment docs.

@saiumesh535
Copy link
Contributor Author

Thanks! Could you updated the versioned docs as well? 24.8 and 24.9 have it

Sure, let me update it. Thanks!

@SimenB
Copy link
Member

SimenB commented Apr 28, 2020

@saiumesh535 ping 🙂

@saiumesh535
Copy link
Contributor Author

saiumesh535 commented Apr 29, 2020

@saiumesh535 ping 🙂

@SimenB
Hello there! I apologize for the delay. will fix those changes you requested. again thanks and apologies for the delay.

@SimenB
Copy link
Member

SimenB commented Apr 29, 2020

No need to apologize, we're all doing this in our spare time! 🙂

@thymikee thymikee force-pushed the jest-config-testSequencer-example branch from 9a1b92e to 1c391ea Compare May 3, 2020 11:02
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated versioned docs. Skipped 25.1 and 25.3 as they'll soon be folded into 25.x with #9956

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants