Reports returned values on received function not throw when expect .toThrow()
#15541
+133
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for jestjs failed.Built without sensitive environment variables
|
chenesan
force-pushed
the
feat/report_returned_values_on_to_throw
branch
2 times, most recently
from
4a6fcc9 to
34488b0
Compare
chenesan
force-pushed
the
feat/report_returned_values_on_to_throw
branch
from
34488b0 to
5b8943a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement #15525, to reports returned value of received function when that function call not throw with
.toThrow()/.toThrowErrorMatchingSnapshot().To check the format, see the test case in
e2e/__tests__/toThrowErrorMatchingSnapshot.test.ts.Changed Scope
expect: intoThrowMatchers.tsfor eachtoThrowExpectedClass/Message/Regexfunction, passreceivedandreturnedValueOnNotThrowto compose the error message.jest-snapshot: do the same thing but fortoThrowErrorMatchingSnapshot.Test plan
toThrowMatchers.test.tsto make sure it contained returned value messagetoThrowErrorMatchingSnapshot.test.tse2e case to ensure it can report the stringified returned object values, not[Object Object].