Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump jsdom to 23.2.0 #14846

Closed
wants to merge 3 commits into from
Closed

Conversation

blakenetz
Copy link

@blakenetz blakenetz commented Jan 10, 2024

Summary

Update jsdom dependency to 23.2.0 to resolve downstream bugs with CSS selector engine. This issue has been reported in a couple of places, but mainly:

See release notes

Test plan

Ran existing testing suite

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 573f06c
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/659f0dddbff67a0008878211
😎 Deploy Preview https://deploy-preview-14846--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

linux-foundation-easycla bot commented Jan 10, 2024

CLA Not Signed

@SimenB
Copy link
Member

SimenB commented Jan 10, 2024

Thanks for sending a PR!

jsdom has dropped node 16, which I intend to support in the next release. However, creating a custom env with whatever version of jsdom you like should be easier in jest 30 via #14717.

@SimenB SimenB closed this Jan 10, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants