Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce helper package for implementing a custom JSDOM enviroment #14717

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 26, 2023

Summary

Since JSDOM 23 has been released dropping Node 16, people will inevitably ask Jest to upgrade.

This new package makes it trivial to implement the env with a different version of JSDOM, so stuff like https://www.npmjs.com/package/jest-environment-jsdom-thirteen becomes trivial to implement

Test plan

🤷

Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a96d98c
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6563b0feb83a1700080d25f5
😎 Deploy Preview https://deploy-preview-14717--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -0,0 +1,191 @@
/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a copy paste of the existing env with jsdom as a third constructor argument

@SimenB SimenB merged commit 01a923b into jestjs:main Nov 27, 2023
73 checks passed
@SimenB SimenB deleted the abstract-jsdom-env branch November 27, 2023 07:32
@clentfort
Copy link
Contributor

Loving it.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants