Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure atob and btoa are writeable #14446

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 24, 2023

Summary

This is an attempt to solve the issue discovered in remix-run/remix#7220 where atob and btoa (amongst others) aren't writeable.

Test plan

Tests in that repo passes. If CI is happy here, I'll add a test

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit db2a544
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64e73027fe6db4000785103d
😎 Deploy Preview https://deploy-preview-14446--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member Author

SimenB commented Aug 24, 2023

Hmm, no, this doesn't work. The assignment is just ignored…

@SimenB SimenB marked this pull request as ready for review August 24, 2023 10:24
// Node 19 makes performance non-readable. This is probably not the correct solution.
nodeGlobalsKey === 'performance',
value,
writable: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only code change - if people wanna override globals, then sure 🤷

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant