Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pretty-format): print ArrayBuffer and DataView incorrectly #14290

Merged
merged 4 commits into from
Sep 20, 2023
Merged

fix(pretty-format): print ArrayBuffer and DataView incorrectly #14290

merged 4 commits into from
Sep 20, 2023

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Jun 29, 2023

Summary

fix print ArrayBuffer and DataView incorrectly

Test plan

Added

@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a266961
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/650a99bbbd509000088afb8b
😎 Deploy Preview https://deploy-preview-14290--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Dunqing Dunqing mentioned this pull request Jun 29, 2023
Merged
@SimenB
Copy link
Member

SimenB commented Jun 30, 2023

Thanks! Could you sign the CLA?

@SimenB
Copy link
Member

SimenB commented Jun 30, 2023

I do wonder if we need to wait for Jest 30 though, as this will change people's snapshots

@SimenB SimenB added this to the Jest 30 milestone Jun 30, 2023
@Dunqing
Copy link
Contributor Author

Dunqing commented Jun 30, 2023

I do wonder if we need to wait for Jest 30 though, as this will change people's snapshots

Ok. Are there any plans for the release date of Jest 30?

@SimenB
Copy link
Member

SimenB commented Jun 30, 2023

This summer, probably 🙂

SimenB
SimenB approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB enabled auto-merge (squash) September 20, 2023 07:06
@Dunqing
Copy link
Contributor Author

Dunqing commented Sep 20, 2023

I think this #14408 should be the same problem, Do you have time take a look that

@SimenB SimenB merged commit c13c649 into jestjs:main Sep 20, 2023
60 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
@SimenB
Copy link
Member

SimenB commented Oct 30, 2023

https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Jest 30
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @SimenB