Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add jest-worker's missing dependency #13341

Merged
merged 6 commits into from
Sep 30, 2022

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented Sep 29, 2022

Summary

We use it here https://github.com/facebook/jest/blob/main/packages/jest-worker/src/workers/threadChild.ts#L9, but no in deps https://github.com/facebook/jest/blob/main/packages/jest-worker/package.json#L19

Ref: webpack-contrib/css-minimizer-webpack-plugin#198

Test plan

No need, but make sense to setup the linter (the rule for eslint) to catch these problems

@facebook-github-bot
Copy link
Contributor

Hi @alexander-akait!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title fix: jest-worker standalone usage fix: add jest-worker's missing dependency Sep 30, 2022
@SimenB SimenB merged commit 9adadc4 into jestjs:main Sep 30, 2022
@SimenB
Copy link
Member

SimenB commented Sep 30, 2022

No need, but make sense to setup the linter (the rule for eslint) to catch these problems

Agreed, surprised it's not set up already

@SimenB
Copy link
Member

SimenB commented Sep 30, 2022

@SimenB
Copy link
Member

SimenB commented Sep 30, 2022

@alexander-akait alexander-akait deleted the fix-worker-standalone-usage branch October 6, 2022 12:30
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants