Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix inconsistent workspace prefixes #13217

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Sep 7, 2022

Summary

Some packages in this yarn workspace depend on other packages in the same workspace. Such dependencies were present using both workspace:* and workspace:^ workspace-style prefixes. These have the same meaning as they will effectively depend on the current version of the package from the workspace. workspace:^ was several times more common in the workspace than workspace:* so I switched everywhere to use that.

I was also able to stop ignoring these workspace-prefix dependencies in the workspace constraint checker (which checks that we use consistent versions in the workspace).

Test plan

Internal-only change.

@bmish bmish force-pushed the fix-inconsistent-workspace-prefix branch from 4bc2953 to b96d18a Compare September 7, 2022 02:53
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

@SimenB SimenB merged commit 818b36b into jestjs:main Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants