Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct grammar #13194

Merged
merged 2 commits into from
Aug 31, 2022
Merged

docs: correct grammar #13194

merged 2 commits into from
Aug 31, 2022

Conversation

momokid
Copy link
Contributor

@momokid momokid commented Aug 31, 2022

Summary

Grammatically updated the website documentation

old doc grammar
updated doc grammar

@mrazauskas
Copy link
Contributor

Thanks! Could you fix docs/GettingStarted.md as well, please? This is Getting Started page for the Next version.

@Biki-das
Copy link
Contributor

Thanks! please update all the versioned docs!

@momokid
Copy link
Contributor Author

momokid commented Aug 31, 2022

Than

Thanks! Could you fix docs/GettingStarted.md as well, please? This is Getting Started page for the Next version.

Yes please I can do that. Thank you.

@mrazauskas
Copy link
Contributor

Thanks! Looks good to me.

@momokid
Copy link
Contributor Author

momokid commented Aug 31, 2022

Thanks! Looks good to me.
Thanks for the guide. I really appreciate it.

SimenB
SimenB approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

@SimenB SimenB changed the title Updated the documentation's grammar docs: correct grammar Aug 31, 2022
@SimenB SimenB merged commit f1deacc into jestjs:main Aug 31, 2022
@momokid
Copy link
Contributor Author

momokid commented Aug 31, 2022

sweet, thanks!
Thank you.

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@momokid @mrazauskas @Biki-das @SimenB @facebook-github-bot