fix: increase the maximum possible file size that jest-haste-map can handle #13094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the read file is decoded using UTF8 regardless of whether the worker needs to or not. This bottlenecks the maximum file size that the worker can hash to ~536MB (maximum length of a string) which causes a hard crash if exceeded. For files that don't need to be decoded and are only hashed, this change allows the worker to hash the file without decoding it, leaving it as a buffer. Since buffers have a maximum size of ~2GB on 64-bit systems, this increases the maximum possible file size significantly.
For files that were already successfully decoded in previous steps (eg. JSON files), the worker will continue to hash the already decoded
content
string instead of rereading the file.Test plan
Tests for the hashing are already handled in
jest-haste-map/src/__tests__/worker.test.js