Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: testSequencer example use destructured arguments #12915

Merged
merged 2 commits into from
Jun 10, 2022
Merged

docs: testSequencer example use destructured arguments #12915

merged 2 commits into from
Jun 10, 2022

Conversation

DanRowe
Copy link
Contributor

@DanRowe DanRowe commented Jun 6, 2022

Summary

Minor documentation change. The example for the testSequencer incorrectly references shardCount and shardIndex through options when they have already been destructured and options is not defined. I noticed this when copying the example file to use in my local environment

Test plan

All automated tests should pass. This is just a syntax change in a documentation example.

@facebook-github-bot
Copy link
Contributor

Hi @DanRowe!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mrazauskas
Copy link
Contributor

Thanks!

Could you fix the same issue in Configuration.md from docs and website/versioned_docs/version-28.0 directories as well, please?

@DanRowe
Copy link
Contributor Author

DanRowe commented Jun 7, 2022

@mrazauskas Done! Thanks for pointing that out.

@mrazauskas
Copy link
Contributor

@SimenB Looks like this PR is ready to land.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 920b0e3 into jestjs:main Jun 10, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
@DanRowe DanRowe deleted the patch-1 branch July 11, 2022 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants