-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs) clarify expect.any #12266
fix(docs) clarify expect.any #12266
Conversation
`expect.any` claims that it will check an object is created with a given constructor. This doesn't match the example following it since numbers are not created using the number constructor (they may be obtained with the number constructor called as a function).
cc @SimenB "First-time contributors need a maintainer to approve running workflows" since we know each other as fake-timers maintainers |
Codecov Report
@@ Coverage Diff @@
## main #12266 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 328 328
Lines 17246 17246
Branches 5071 5071
=======================================
Hits 11643 11643
Misses 5570 5570
Partials 33 33 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Sure, let me update and push |
Done |
thanks @benjamingr |
thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
expect.any
claims that it will check an object is created with a given constructor. This doesn't match the example following it since numbers are not created using the number constructor (they may be obtained with the number constructor called as a function).Summary
Clarify the documentation for
expect.any
to explain the behavior for primitives is different from the one for objects.