-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move codeblock title to props & use line highlight #11991
Conversation
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #11991 +/- ##
=======================================
Coverage 68.74% 68.74%
=======================================
Files 323 323
Lines 16649 16649
Branches 4808 4808
=======================================
Hits 11445 11445
Misses 5171 5171
Partials 33 33 Continue to review full report at Codecov.
|
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow, this is great! thanks for taking the time to do this
Welcome :D Simple regex search & replace, then ten minutes of manual review |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Many of the code blocks on the website are not directly copyable: because of the use of
diff
, and because of the comment directive used to indicate the file title. Docusaurus actually provides thetitle
andhighlight-line
APIs to make them more accessible.A simple regex search & replace to put all the titles in the
title
field.Test plan
Before:
After: