-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat: Add GitHub Actions Reporter #11320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
4b441a1
Add GitHub Actions Reporter
ockham 6b299e2
Use plural to match filename
ockham b6cb64b
More expressive test failure message
ockham 48e2778
Fix line and col by making the RegEx less greedy
ockham 195062d
Disable outside of GitHub Actions
ockham 808bd5c
Fix test description
ockham 5c4884f
Add test case for non-GHA context
ockham 97a7b1c
Whitespace
ockham fc6dd30
Use ci-info to check for GHA
ockham 6289d6a
Escape all 3 chars that require it
ockham 5ab275e
Update snapshot
ockham ec6eb0d
Add Changelog entry
ockham a35a0d9
Add missing modifier
ockham e72e447
No need for snapshot
ockham 20a6562
Remove now-obsolete snapshot
ockham d8c0454
Capitalize H in GithubActionsReporter
ockham c7c4ac0
More capital H's in GitHub
ockham bb4bbe6
Use Node's flatMap
ockham e4d5c01
Drop ci-info check for GHA
ockham 1ae84fb
Strip ANSI codes
ockham 8b5414f
Update test to reflect removal of GHA check
ockham c963d7a
Merge branch 'main' into add/github-actions-reporter
SimenB 0461d49
Update packages/jest-reporters/src/GitHubActionsReporter.ts
SimenB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
import stripAnsi = require('strip-ansi'); | ||
import type {AggregatedResult, TestResult} from '@jest/test-result'; | ||
import BaseReporter from './BaseReporter'; | ||
import type {Context} from './types'; | ||
|
||
const lineAndColumnInStackTrace = /^.*?:([0-9]+):([0-9]+).*$/; | ||
|
||
function replaceEntities(s: string): string { | ||
// https://github.com/actions/toolkit/blob/b4639928698a6bfe1c4bdae4b2bfdad1cb75016d/packages/core/src/command.ts#L80-L85 | ||
const substitutions: Array<[RegExp, string]> = [ | ||
[/%/g, '%25'], | ||
[/\r/g, '%0D'], | ||
[/\n/g, '%0A'], | ||
SimenB marked this conversation as resolved.
Show resolved
Hide resolved
|
||
]; | ||
return substitutions.reduce((acc, sub) => acc.replace(...sub), s); | ||
} | ||
|
||
export default class GitHubActionsReporter extends BaseReporter { | ||
onRunComplete( | ||
_contexts?: Set<Context>, | ||
aggregatedResults?: AggregatedResult, | ||
): void { | ||
const messages = getMessages(aggregatedResults?.testResults); | ||
|
||
for (const message of messages) { | ||
this.log(message); | ||
} | ||
} | ||
} | ||
|
||
function getMessages(results: Array<TestResult> | undefined) { | ||
if (!results) return []; | ||
|
||
return results.flatMap(({testFilePath, testResults}) => | ||
testResults | ||
.filter(r => r.status === 'failed') | ||
.flatMap(r => r.failureMessages) | ||
.map(m => stripAnsi(m)) | ||
.map(m => replaceEntities(m)) | ||
.map(m => lineAndColumnInStackTrace.exec(m)) | ||
.filter((m): m is RegExpExecArray => m !== null) | ||
.map( | ||
([message, line, col]) => | ||
`::error file=${testFilePath},line=${line},col=${col}::${message}`, | ||
), | ||
); | ||
} |
118 changes: 118 additions & 0 deletions
118
packages/jest-reporters/src/__tests__/GitHubActionsReporter.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
'use strict'; | ||
|
||
let GitHubActionsReporter; | ||
|
||
const write = process.stderr.write; | ||
const globalConfig = { | ||
rootDir: 'root', | ||
watch: false, | ||
}; | ||
|
||
let results = []; | ||
|
||
function requireReporter() { | ||
jest.isolateModules(() => { | ||
GitHubActionsReporter = require('../GitHubActionsReporter').default; | ||
}); | ||
} | ||
|
||
beforeEach(() => { | ||
process.stderr.write = result => results.push(result); | ||
}); | ||
|
||
afterEach(() => { | ||
results = []; | ||
process.stderr.write = write; | ||
}); | ||
|
||
const aggregatedResults = { | ||
numFailedTestSuites: 1, | ||
numFailedTests: 1, | ||
numPassedTestSuites: 0, | ||
numTotalTestSuites: 1, | ||
numTotalTests: 1, | ||
snapshot: { | ||
added: 0, | ||
didUpdate: false, | ||
failure: false, | ||
filesAdded: 0, | ||
filesRemoved: 0, | ||
filesRemovedList: [], | ||
filesUnmatched: 0, | ||
filesUpdated: 0, | ||
matched: 0, | ||
total: 0, | ||
unchecked: 0, | ||
uncheckedKeysByFile: [], | ||
unmatched: 0, | ||
updated: 0, | ||
}, | ||
startTime: 0, | ||
success: false, | ||
testResults: [ | ||
{ | ||
numFailingTests: 1, | ||
numPassingTests: 0, | ||
numPendingTests: 0, | ||
numTodoTests: 0, | ||
openHandles: [], | ||
perfStats: { | ||
end: 1234, | ||
runtime: 1234, | ||
slow: false, | ||
start: 0, | ||
}, | ||
skipped: false, | ||
snapshot: { | ||
added: 0, | ||
fileDeleted: false, | ||
matched: 0, | ||
unchecked: 0, | ||
uncheckedKeys: [], | ||
unmatched: 0, | ||
updated: 0, | ||
}, | ||
testFilePath: '/home/runner/work/jest/jest/some.test.js', | ||
testResults: [ | ||
{ | ||
ancestorTitles: [Array], | ||
duration: 7, | ||
failureDetails: [Array], | ||
failureMessages: [ | ||
` | ||
Error: \u001b[2mexpect(\u001b[22m\u001b[31mreceived\u001b[39m\u001b[2m).\u001b[22mtoBe\u001b[2m(\u001b[22m\u001b[32mexpected\u001b[39m\u001b[2m) // Object.is equality\u001b[22m\n | ||
\n | ||
Expected: \u001b[32m\"b\"\u001b[39m\n | ||
Received: \u001b[31m\"a\"\u001b[39m\n | ||
at Object.<anonymous> (/home/runner/work/jest/jest/some.test.js:4:17)\n | ||
at Object.asyncJestTest (/home/runner/work/jest/jest/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)\n | ||
at /home/runner/work/jest/jest/node_modules/jest-jasmine2/build/queueRunner.js:45:12\n | ||
at new Promise (<anonymous>)\n | ||
at mapper (/home/runner/work/jest/jest/node_modules/jest-jasmine2/build/queueRunner.js:28:19)\n | ||
at /home/runner/work/jest/jest/node_modules/jest-jasmine2/build/queueRunner.js:75:41\n | ||
at processTicksAndRejections (internal/process/task_queues.js:93:5) | ||
`, | ||
], | ||
fullName: 'asserts that a === b', | ||
location: null, | ||
numPassingAsserts: 0, | ||
status: 'failed', | ||
title: 'asserts that a === b', | ||
}, | ||
], | ||
}, | ||
], | ||
}; | ||
|
||
test('reporter extracts the correct filename, line, and column', () => { | ||
requireReporter(); | ||
const testReporter = new GitHubActionsReporter(globalConfig); | ||
testReporter.onRunComplete(new Set(), aggregatedResults); | ||
expect(results.join('').replace(/\\/g, '/')).toMatchSnapshot(); | ||
}); |
6 changes: 6 additions & 0 deletions
6
packages/jest-reporters/src/__tests__/__snapshots__/GitHubActionsReporter.test.js.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`reporter extracts the correct filename, line, and column 1`] = ` | ||
"::error file=/home/runner/work/jest/jest/some.test.js,line=4,col=17::%0A Error: expect(received).toBe(expected) // Object.is equality%0A%0A %0A%0A Expected: "b"%0A%0A Received: "a"%0A%0A at Object.<anonymous> (/home/runner/work/jest/jest/some.test.js:4:17)%0A%0A at Object.asyncJestTest (/home/runner/work/jest/jest/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)%0A%0A at /home/runner/work/jest/jest/node_modules/jest-jasmine2/build/queueRunner.js:45:12%0A%0A at new Promise (<anonymous>)%0A%0A at mapper (/home/runner/work/jest/jest/node_modules/jest-jasmine2/build/queueRunner.js:28:19)%0A%0A at /home/runner/work/jest/jest/node_modules/jest-jasmine2/build/queueRunner.js:75:41%0A%0A at processTicksAndRejections (internal/process/task_queues.js:93:5)%0A | ||
" | ||
`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.