Fix location for test.each
#10413
Merged
Fix location for test.each
#10413
+76
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apexskier
force-pushed
the
10412-location-in-each
branch
3 times, most recently
from
a26fef7
to
7b9a72d
Compare
apexskier
force-pushed
the
10412-location-in-each
branch
from
7b9a72d
to
af9414a
Compare
SimenB
approved these changes
Aug 16, 2020
|
Thanks for the changelog reminder! |
|
@mattphillips would you be able to give this a look? |
|
@mattphillips @SimenB Any updates on getting this merged? |
|
I'll merge friday to give @mattphillips a few more days 🙂 |
This was referenced Nov 18, 2020
|
Note that this was still broken on Windows using |
This was referenced Mar 28, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10412
I'm not sure what the best approach to solving this is. I don't want to add code into
packages/jest-each/src/bind.ts, since the callsite stuff is runner specific. But, where the location is added injest/packages/jest-jasmine2/src/index.ts(and circus equivalent) doesn't appear to have a way to know that the spec usedeach.What I've come up isn't great. I'm basically checking if the first result found is in the
jest-eachmodule, and replacing it if so. I'd appreciate suggestions for other methods.Test plan
Introduces failing tests that demonstrate the problem and fix them.