mark "todo" tests as skipped #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaarghk
commented
Oct 9, 2023
| "numPendingTestSuites": 0, | ||
| "numPendingTests": 0, | ||
| "numRuntimeErrorTestSuites": 0, | ||
| "numTodoTests": 1, |
There was a problem hiding this comment.
I'm not sure if this always comes out set to 0 - if so I think the rest of the .json files should be updated to reflect this ...
| @@ -226,7 +236,7 @@ module.exports = function (report, appDirectory, options, rootDir = null) { | |||
| name: replaceVars(suiteOptions.suiteNameTemplate, suiteNameVariables), | |||
| errors: suiteErrors, | |||
| failures: suite.numFailingTests, | |||
| skipped: suite.numPendingTests, | |||
| skipped: suite.numPendingTests + (suite.numTodoTests ? suite.numTodoTests : 0), | |||
There was a problem hiding this comment.
... and the numTodoTests ? numTodoTests : 0 in this file updated to just numTodoTests.
But, if numTodoTests only comes out after a certain Jest version, and it would entail bumping them minimum compatible version of jest in this library's package.json, then I suppose it's fine to leave the test harness and this line as-is.
Anyone know?
maaarghk
force-pushed
the
mark-todo-tests-skipped
branch
from
11d9753 to
f83b444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #242
messageattr is used to differentiate these fromit.skipbut I don't think it makes a difference; this output matches what I expect from using mocha-junit-exporter previously