-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for test suite properties. Upgrade mkdirp. Drop node < 10 support #129
Add support for test suite properties. Upgrade mkdirp. Drop node < 10 support #129
Conversation
Can you help me to understand if there is anything specific in jest 25 that will stop working with jest-junit? |
No it should work just fine with older versions of jest, even far below 25. But older versions of jest used to support node 8. So really this recent change just updates node.js support. |
So you could basically still test against node 10 and jest v25 but decided to not do that? |
My thought process when maintaining jest-junit this entire time has been to share the same runtime requirements as jest. But you're making me think that I should at least test for earlier versions of jest in CI. But right now I see no reason the latest jest-junit wouldn't work in several older jest versions. |
Ok I've re-added CI testing for node >= 10 and jest >= 22.0.0. So for the time being we know 11.0.0 has support for this and I'll do my best to keep it that way. Thanks for commenting! |
Thank you for reconsidering, it provides confidence. |
This PR addresses the mkdirp security vulnerability by upgrading to the latest version.
This also drops node < 10 support for jest-junit.
As of Jest v26.0.0 jest itself no longer supports node < 10.
This PR also adds the ability to define custom test suite properties.