fix: ensure jest globals are enabled in styles config
#1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
enable-globals-in-styles
branch
from
2a020ad
to
eb781eb
Compare
SimenB
approved these changes
Sep 9, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
## [27.0.3](v27.0.2...v27.0.3) (2022-09-09) ### Bug Fixes * ensure jest globals are enabled in `styles` config ([#1241](#1241)) ([a165e98](a165e98))
|
🎉 This PR is included in version 27.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SimenB
pushed a commit
to bmish/eslint-plugin-jest
that referenced
this pull request
Sep 10, 2022
## [27.0.3](jest-community/eslint-plugin-jest@v27.0.2...v27.0.3) (2022-09-09) ### Bug Fixes * ensure jest globals are enabled in `styles` config ([jest-community#1241](jest-community#1241)) ([a165e98](jest-community@a165e98))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us avoid having to do ugly things in #1226 when accessing
configs[config].rules[rule](which currently we're@ts-ignore-ing) because it makes all configs of the same type.I've labeled this as a fix because I think that is technically true given we're being inconsistent vs the other configs; this also could arguably be a breaking change and we have also spoken about removing the globals at some point once we had proper scope resolving.
@SimenB will wait for you to weight in on if you're happy to land this or if you think it should be in a major version (in which case I'll do something different)