fix(no-large-snapshots): actually compare allowed name strings to name (

#625)
jest-community · Jul 26, 2020 · 622a08c · 622a08c
1 parent b269e88
commit 622a08c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/rules/__tests__/no-large-snapshots.test.ts b/src/rules/__tests__/no-large-snapshots.test.ts
@@ -217,6 +217,27 @@ ruleTester.run('no-large-snapshots', rule, {
         },
       ],
     },
+    {
+      // "should not report whitelisted large snapshots based on regexp"
+      filename: '/mock-component.jsx.snap',
+      code: [
+        generateExportsSnapshotString(58, 'a big component w/ text'),
+        generateExportsSnapshotString(58, 'a big component 2'),
+      ].join('\n\n'),
+      options: [
+        {
+          whitelistedSnapshots: {
+            '/mock-component.jsx.snap': ['a big component 2'],
+          },
+        },
+      ],
+      errors: [
+        {
+          messageId: 'tooLongSnapshots',
+          data: { lineLimit: 50, lineCount: 58 },
+        },
+      ],
+    },
   ],
 });
 

diff --git a/src/rules/no-large-snapshots.ts b/src/rules/no-large-snapshots.ts
@@ -58,7 +58,7 @@ const reportOnViolation = (
           return name.test(snapshotName);
         }
 
-        return snapshotName;
+        return snapshotName === name;
       });
     }
   }