Add "CopyToClipboard" command to ConfirmationController

[kyu08]

PR Description

Sometimes, I want to copy the error message to clipboard to search google or ask to LLM about the error message.

So I added CopyToClipboard command to ConfirmationController and I have confirmed that this command copies the content of the window to the clipboard.

Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go generate ./...)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
• Docs have been updated if necessary
• You've read through your own file changes for silly mistakes etc

[stefanhaller]

Nice, seems useful.

Two things:

• there's no feedback when pressing the key; usually we show a toast in the status line, but apparently toasts are suppressed when a popup is showing? Would have to investigate why, or if it's possible to change that.
• I feel the <c-o> keybinding should not be between enter and esc, but to the right of esc, which is by far the more important key to know about. However, then it ends up between the two esc bindings, so that would have to be solved first.

[kyu08]

Thanks for the feedback!

• there's no feedback when pressing the key; usually we show a toast in the status line, but apparently toasts are suppressed when a popup is showing? Would have to investigate why, or if it's possible to change that.

I'll look into it.

• I feel the keybinding should not be between enter and esc, but to the right of esc, which is by far the more important key to know about.

That's right! This is fixed in e7505c4.
EDIT: I squashed this change into 8ee1f35 when I rebased onto master.

However, then it ends up between the two esc bindings, so that would have to be solved first.

So how about adding an implementation like this first, then merging this PR, and then deleting unnecessary key bindings?

[kyu08]

• there's no feedback when pressing the key; usually we show a toast in the status line, but apparently toasts are suppressed when a popup is showing? Would have to investigate why, or if it's possible to change that.

I found the cause. self.c.OS().CopyToClipboard(text) does not simply call the Toast() method .
So it might be fine to just call it in the Handler.
Fixed in 494edfc.
EDIT: I squashed this change into 8ee1f35 when I rebased onto master.

[kyu08]

After merging #4819, I will reopen this PR.

[kyu08]

@stefanhaller
I have rebased onto master and I have confirmed that the key bindings line looks okay.

And this is a message when <c-o> is pressed.

I used Popup panel content because this ui element is called PopupPanel in the source code and I thought this term would be easy for users to understand as well.

[stefanhaller]

Nice, looks mostly good. I added a fixup to disable the command for editable prompts (e.g. new branch name); while it would technically be possible to copy the branch name that you just typed, I don't think this is the intended use, and I'd rather not see the extra keybinding appear in the status bar in this case.

Also took that opportunity to move the handler to a method.

Finally, I added another fixup to add an integration test.

I hope you don't mind my changing your PRs so much, but for me this is a more efficient way of working than to tell you what I would like to see changed.

[stefanhaller]

This needs to be i18n'ed too. I added 79f1d7c to do this. We can't use the existing Tr.CopiedToClipboard text here, this is only for hashes or branch names etc., so we need to add a new text for this.

[kyu08]

I hope you don't mind my changing your PRs so much, but for me this is a more efficient way of working than to tell you what I would like to see changed.

Thank you for your thoughtful consideration.
It's totally fine for me.

Your support actually helped make the code much better. Thank you so much. And your changes looks good to me too.