Fix layout of options view for non-english languages #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
jesseduffield
approved these changes
Mar 5, 2025
The width calculations didn't take multi-byte characters into account.
stefanhaller
force-pushed
the
fix-layout-of-options-bar
branch
from
98dbf66 to
b316072
Compare
stefanhaller
added a commit
that referenced
this pull request
Mar 6, 2025
- **PR Description** When changing the language in the config file while lazygit is running, the panel titles and tab titles weren't properly updated. I noticed this while working on #4359. Probably not an important feature for users, because they are unlikely to change the language all the time; but it's still nice if this isn't broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The width calculations didn't take multi-byte characters into account, so the options bar was cut off too early for these.
Fixes #4353.