Standardise on 'screen mode' naming convention

[jesseduffield]

We had some conflicting names: screen-mode, window-size, and window-maximisation. I think panel-size sounds good.

• PR Description

• Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go generate ./...)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
• Docs have been updated if necessary
• You've read through your own file changes for silly mistakes etc

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 2c321011	✅ 92.59%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (2c32101)	Report Missing	Report Missing	Report Missing
Head commit (28d10c2)	51737	44715	86.43%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#4142)	27	25	92.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[jesseduffield]

@stefanhaller I've added a blocks-release tag to this because prior commits in this release proliferate the inconsistency in naming

[stefanhaller]

(@jesseduffield I hadn't noticed that you requested my review here. I'm not trained to look for that since you usually merge your things without review. Would you mind tagging me in a comment in such cases?)

I wonder if panel-size is really better than screen-mode. The problem with panel size is that the width of the panels can change for reasons other than changing the screen mode. For example, changing the gui.sidePanelWidth config changes the panel width but not the screen mode, so a variable like NEEDS_RERENDER_ON_WIDTH_CHANGE_WHEN_PANEL_SIZE_CHANGES is quite misleading now. This is really only relevant for screen mode changes, but it now sounds like it applies to any panel size change, and we don't have a way to distinguish the two by name.

I'm not sure if this is important enough to be a blocking objection, just bringing it up as a concern. I guess my own preference would be to call it "screen mode", I kind of like the term (but maybe only because I'm used to it).

[jesseduffield]

Would you mind tagging me in a comment in such cases?)

Yep, will do

Regarding the name, I figured my affinity for screen mode was just due to familiarity as well. However, after asking chatGPT what it would expect a setting called 'screen mode' to control, it seems it's pretty much right about what ours does. I'll update the PR to use screen mode everywhere.

[jesseduffield]

Given the PR is now quite straightforward, I'm gonna go ahead and merge