Collapse/uncollapse all files in tree

[mtrajano]

Seems like this feature is highly requested #4095 #3554

Ability to collpase/expand all files in the tree both for working files and commit view files. One issue I noticed is that currently any functionality that we want to add related to the file tree has to be duplicated across both controllers/models. I would like to try to unite the functionality using generics but I would prefer if it was done as part of a separate PR as it will greatly increase the scope of this PR and doesn't look trivial. Any feedback is welcome, thanks!

Example of functionality working:

[stefanhaller]

What keymaps if any to add to these

I could imagine - for collapsing, and = for expanding. At least they are easy to reach on a US keyboard layout. Anybody got any better ideas?

should the functionality be to toggle vs collapse and uncollapse separately

I would probably do separate ones. For toggling it wouldn't be quite clear what the exact logic would be.

and if this should be added anywhere else (right now it's just for the file tree)

Yes, in commits_files_controller.go; this handles the list of files that you see when pressing enter on a commit. I'm not aware of any other places besides these two.

[jesseduffield]

I could imagine - for collapsing, and = for expanding.

That sounds good to me

[mtrajano]

@jesseduffield @stefanhaller This pr is ready as well with localization and an integration test. I noticed there is a plan to add generics to generalize the logic between commit files and the files view but it does not look trivial. I can give it a shot in a separate pr although I might have some questions.

[jesseduffield]

Just one comment, otherwise LGTM. Tested it out and it works great

[jesseduffield]

Suggested change

	CollapseAllTooltip: "Collapse all entries in the files tree",
	CollapseAllTooltip: "Collapse all directories in the files tree",

Likewise with below

[stefanhaller]

Fixed in d5374ac.

[jesseduffield]

I noticed there is a plan to add generics to generalize the logic between commit files and the files view but it does not look trivial. I can give it a shot in a separate pr although I might have some questions.

That would be great! Happy to answer any questions you have

[stefanhaller]

I tested this and it works nicely, but what I'm missing is to keep the selection (if possible). This won't always be possible, e.g. when collapsing it will only be possible if a top-level entry is selected, and I'd be ok with the selection jumping to an arbitrary top-level entry when that's not the case (although it would be nice if it would jump to the top-level entry which is a parent of what's currently selected; this doesn't seem super important though). When expanding, however, it should always be possible, and it's a bit annoying that it isn't right now.

[stefanhaller]

Ok, I had a bit of a closer look at the code and found a few more things that can be improved. I pushed two commits, please see their commit messages for details.

[jesseduffield]

Those changes look good to me @stefanhaller

[stefanhaller]

I added one more commit (b04d1f5) that renames some UncollapseAll methods to ExpandAll, since that seems to be the terminology we're using for this.

I'm gonna squash this now, this is ready to merge from my side.