Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of windowSize when passing a git arg #3223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayyess
Copy link

@ayyess ayyess commented Jan 15, 2024

  • PR Description

Previously, lazygit status, log, or branch always opened in a full
window size regardless of the gui.windowSize value. Now,
gui.panelWindowSize configures the window size per arg (and no arg can
be configured as "main") regardless of requested filter path.

Closes #3042

Happy for feedback:

  • Tests not added
    • I tried in pkg/integration/tests/branch/set_upstream.go but SetupConfig didn't have an effect. Should this work or is SetupConfig too late for this?
  • panelWindowSize.PatternProperties is hardcoded
    • Same as windowSize
    • I tried to move permittedValues from entry_point.go to types.go to use from user_config.go but there were circular imports on integrationTypes.
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Previously, lazygit status, log, or branch always opened in a full
window size regardless of the gui.windowSize value. Now,
gui.panelWindowSize configures the window size per arg (and no arg can
be configured as "main") regardless of requested filter path.

Closes jesseduffield#3042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Launching a panel with a specified window size.
1 participant