Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of delete named branch added #301

Merged
merged 4 commits into from
Oct 23, 2018

Conversation

rozuur
Copy link
Contributor

@rozuur rozuur commented Oct 6, 2018

WIP for fixing #236

@codecov-io
Copy link

codecov-io commented Oct 6, 2018

Codecov Report

Merging #301 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          12       12           
  Lines        1691     1691           
=======================================
  Hits         1591     1591           
  Misses         98       98           
  Partials        2        2
Impacted Files Coverage Δ
pkg/i18n/english.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f6460...3a23cb8. Read the comment docs.

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works perfectly! I've just got one comment about the prompt message/keybinding

rozuur and others added 2 commits October 21, 2018 21:13
And force delete messages gives feedback about merge status
@jesseduffield
Copy link
Owner

Works for me, thanks for making this PR! :)

@jesseduffield jesseduffield merged commit c6da4c8 into jesseduffield:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants